[ARIES-2161] update destroy method to be compatible with spring 6 #299
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @f2par0 |
f2par0
changed the title
f2par0
force-pushed
the
fde/spring-fix
branch
from
b1f4597 to
a1c0cd5
Compare
alien11689
reviewed
Dec 2, 2024
blueprint/blueprint-spring/pom.xml
Outdated
| @@ -119,13 +119,13 @@ | |||
| <dependency> | |||
| <groupId>org.springframework</groupId> | |||
| <artifactId>spring-context</artifactId> | |||
| <version>4.2.2.RELEASE</version> | |||
| <version>6.1.15</version> | |||
There was a problem hiding this comment.
I checked that spring 6.x does not work with minimal java 8 that we should have in the repo
you can find the errors by running:
mvn -f blueprint/blueprint-spring clean package
or checking your branch with definition of blueprint build from #297
There was a problem hiding this comment.
yes, spring 6 is for java 17, so if java 8 support is required, the latest version is 5.3.39.
blueprint/blueprint-spring/pom.xml
Outdated
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> | ||
| <target>1.7</target> |
There was a problem hiding this comment.
java 8 should be minimal supported version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem found : the class
SpringApplicationContextinherits fromorg.springframework.context.support.AbstractApplicationContext, which had adestroymethod in version 4, but was deprecated then removed in the version 6 of spring framework.The name of the destroy method must be updated to match this new name