Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(asset): pass dag kwargs to asset decorator #44278

Closed
wants to merge 1 commit into from
Closed

feat(asset): pass dag kwargs to asset decorator #44278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions task_sdk/src/airflow/sdk/definitions/asset/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,17 @@ class AssetDefinition(Asset):

function: Callable
schedule: ScheduleArg
dag_kwargs: dict[str, Any] = attrs.field(factory=dict)

def __attrs_post_init__(self) -> None:
parameters = inspect.signature(self.function).parameters

with DAG(dag_id=self.name, schedule=self.schedule, auto_register=True):
with DAG(
dag_id=self.name,
schedule=self.schedule,
auto_register=True,
**self.dag_kwargs,
):
_AssetMainOperator(
task_id="__main__",
inlets=[
Expand Down Expand Up @@ -113,7 +119,7 @@ def serialize(self):
}


@attrs.define(kw_only=True)
@attrs.define(init=False, kw_only=True, unsafe_hash=False)
class asset:
"""Create an asset by decorating a materialization function."""

Expand All @@ -122,6 +128,24 @@ class asset:
group: str = ""
extra: dict[str, Any] = attrs.field(factory=dict)

_dag_kwargs: dict[str, Any] = attrs.field(factory=dict)

def __init__(
self,
*,
schedule: ScheduleArg,
uri: str | ObjectStoragePath | None = None,
group: str = "",
extra: dict[str, Any] = attrs.field(factory=dict),
**kwargs: dict[str, Any],
):
self.schedule = schedule
self.uri = uri
self.group = group
self.extra = extra

self._dag_kwargs = kwargs

def __call__(self, f: Callable) -> AssetDefinition:
if (name := f.__name__) != f.__qualname__:
raise ValueError("nested function not supported")
Expand All @@ -133,4 +157,5 @@ def __call__(self, f: Callable) -> AssetDefinition:
extra=self.extra,
function=f,
schedule=self.schedule,
dag_kwargs=self._dag_kwargs,
)
Loading