Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped apostrophes before checking for skipped words + performance enhancement #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

azzurro
Copy link
Contributor

@azzurro azzurro commented Aug 4, 2020

Fixed issue with apostrophe in string making the entire word/sentence valid regardless of spell errors.

Possibly related: #48

@azzurro azzurro changed the title escaped apostrophes before checking for skipped words + performance enhancement Escaped apostrophes before checking for skipped words + performance enhancement Aug 4, 2020
@aegirokran
Copy link

@azzurro - could this be made to work with both the regular apostrophe ' also the smart quotes ?

For example:
shouldn't - regular quotes
shouldn’t - smart quotes

Sometimes they're called smart quotes or curly quotes and more info here - https://smartquotesforsmartpeople.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants