Performance is not good enough

[borisyankov]

Thanks for the work on this project. We get a lot out of it at Zulip Mobile

We find the performance regression that happened in 0.0.7 makes the plugin impractical for us, so we are sticking to 0.0.6 for the time being. The difference in run speed is 10 seconds for 0.0.6 vs about a minute for 0.0.7+ (including the latest 0.0.10).

It would be great to be able to use the latest version but we can't justify raising our ESlint runtime that much.

[aotaduy]

Hi Boris

Can you provide me with a sample project to be able to debug this quickly and try to get a solution.
I got some other users complaining about the performance and i would like to fix it, or at least add some options so you can configure the plugin to your needs and get the benefits of using the latest version. I think we added some regular expressions that are not necesary for all the cases and we could boost the performance if we get rid of those.

Maybe you can send me an old version of some of your projects so i can test a real use case. I can commit to non disclose the code if is not open source.

Yo can send me an email with your contact details if you want to discuss this privately.

Regards
Andres

[borisyankov]

Hey Andres,

I think our open source project is a good code-base to test against:
https://github.com/zulip/zulip-mobile/

[aotaduy]

Hi Boris

I was doing some tests with your code. I have just published a fix, that boost performance to the 0.0.6 levels. Looks like I have been reading the dictionary a lot of times from disk.
This is fixed now.
Now the plugin is reporting a few more spelling error for your project it migh be for some difference in the configuration options.
I think you might need to add some extra skipWords and
- 'https://[^s]*'
to be able to skip https urls

Thanks For your feedback!
Regards

[aotaduy]

@jrencz Please take a look at this one.
Thanks!