Update ForEachObjectArray.js #675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faf4a
approved these changes
Oct 26, 2024
USERSATOSHI
requested changes
Nov 12, 2024
Comment on lines
+27
to
+28
| for (const key in d.data.objects[name][property]) { | ||
| if (d.data.objects[name][property].hasOwnProperty(key)) { |
There was a problem hiding this comment.
need a check before this for loop to see if d.data.objects[name][property] is an iterable else it will error out
|
cc: @supremesupreme resolve requested changes |
Faf4a
added
state: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed it in a case where it wasnt looping thought the arrays
Fixes # (issue number / remove this line if no issue is to be referenced)
Type of change
Please check options that describe your Pull Request: