Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$forEachObjectArray function #661

Merged
merged 5 commits into from
Oct 5, 2024
Merged

$forEachObjectArray function #661

merged 5 commits into from
Oct 5, 2024

Conversation

supremesupreme
Copy link
Collaborator

Description

$ForEachObjectArray loops through objects in array and returns in awaited command also Modified $awaitData to return prop if no option provided

Fixes # (issue number / remove this line if no issue is to be referenced)

Type of change

Please check options that describe your Pull Request:

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and changes

src/functions/ForEachObjectArray.js Outdated Show resolved Hide resolved
src/functions/ForEachObjectArray.js Outdated Show resolved Hide resolved
src/functions/ForEachObjectArray.js Outdated Show resolved Hide resolved
src/functions/ForEachObjectArray.js Outdated Show resolved Hide resolved
src/functions/awaitData.js Outdated Show resolved Hide resolved
Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Faf4a Faf4a changed the title For each object array function $forEachObjectArray function Oct 5, 2024
@Faf4a Faf4a merged commit bc74f2f into v6 Oct 5, 2024
3 checks passed
@Faf4a Faf4a deleted the ForEachObjectArray-Function branch October 5, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants