Fix KW dup (#93)

* Fix KW dup * Tests fix
anzusystems · Nov 19, 2024 · 29f8446 · 29f8446
1 parent 6dccfd6
commit 29f8446
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 13 deletions.
diff --git a/src/Domain/Keyword/KeywordFacade.php b/src/Domain/Keyword/KeywordFacade.php
@@ -30,12 +30,11 @@ public function __construct(
      */
     public function create(Keyword $keyword): Keyword
     {
-        $this->validator->validate($keyword);
-
         $existingKeyword = $this->keywordRepository->findOneByNameAndExtSystem($keyword->getName(), $keyword->getExtSystem());
         if ($existingKeyword) {
             throw new KeywordExistsException($existingKeyword);
         }
+        $this->validator->validate($keyword);
 
         try {
             $this->keywordManager->beginTransaction();

diff --git a/tests/Controller/Api/Adm/V1/KeywordControllerTest.php b/tests/Controller/Api/Adm/V1/KeywordControllerTest.php
@@ -116,10 +116,6 @@ public function testCreateFailure(array $requestJson, array $validationErrors):
 
     public function createFailureDataProvider(): array
     {
-        $existingKeyword = self::getContainer()
-            ->get(KeywordRepository::class)
-            ->find(KeywordFixtures::KEYWORD_1);
-
         return [
             [
                 'requestJson' => [
@@ -134,17 +130,33 @@ public function createFailureDataProvider(): array
                         ValidationException::ERROR_FIELD_EMPTY,
                     ],
                 ],
-            ],
+            ]
+        ];
+    }
+
+    /**
+     * @dataProvider keywordExistsDataProvider
+     */
+    public function testKeywordExists(array $requestJson): void
+    {
+        $client = $this->getApiClient(User::ID_ADMIN);
+
+        $response = $client->post(KeywordUrl::createPath(), $requestJson);
+        $this->assertSame(Response::HTTP_OK, $response->getStatusCode());
+    }
+
+    public function keywordExistsDataProvider(): array
+    {
+        $existingKeyword = self::getContainer()
+            ->get(KeywordRepository::class)
+            ->find(KeywordFixtures::KEYWORD_1);
+
+        return [
             [
                 'requestJson' => [
                     'name' => $existingKeyword->getName(),
                     'extSystem' => ExtSystemFixtures::ID_CMS,
-                ],
-                'validationErrors' => [
-                    'name' => [
-                        ValidationException::ERROR_FIELD_UNIQUE,
-                    ]
-                ],
+                ]
             ],
         ];
     }