Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast episode extUrl, podcast extUrl. #175

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

TomasHermanek
Copy link
Contributor

No description provided.

@TomasHermanek TomasHermanek requested a review from marforon March 12, 2024 09:38
<ARow>
<AFormTextField
v-model="podcast.attributes.extUrl"
:label="t('coreDam.podcast.model.attributes.extUrl')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this label attribute required? I think it should be resolved from v attribute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is possible. But each line of the form has a specified label (also each CRUD form), so more code modification is probably needed, but that's beyond the scope of this PR

@TomasHermanek TomasHermanek merged commit 36ab4a4 into main Mar 12, 2024
2 checks passed
@TomasHermanek TomasHermanek deleted the main_76595_podcast_url branch March 12, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants