Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up cost_model_requested_write_lock_cost #4353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

clean up cost_model_requested_write_lock_cost #4353

wants to merge 2 commits into from

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Jan 8, 2025

Problem

Feature is activated everywhere, feature-gate for cost_model_requested_write_lock_cost is no longer necessary.

          Feature                                      | Status                  | Activation Slot | Description
devnet:   wLckV1a64ngtcKPRGU4S4grVTestXjmNjxBjaKZrAcn | active since epoch 794 | 343008000 | cost model uses number of requested write locks #34819
testnet:  wLckV1a64ngtcKPRGU4S4grVTestXjmNjxBjaKZrAcn | active since epoch 710 | 301196256 | cost model uses number of requested write locks #34819
mainnet:  wLckV1a64ngtcKPRGU4S4grVTestXjmNjxBjaKZrAcn | active since epoch 723 | 312336000 | cost model uses number of requested write locks #34819

Summary of Changes

  • Remove feature-gate code for cost_model_requested_write_lock_cost

Fixes #

@apfitzge apfitzge marked this pull request as ready for review January 8, 2025 18:58
@apfitzge apfitzge requested a review from tao-stones January 8, 2025 18:58
tao-stones
tao-stones previously approved these changes Jan 8, 2025
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @tao-stones