verifies that the signatures are the same when recovering Merkle shreds #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leader signs the Merkle root and shreds in the same erasure batch have the same Merkle root. So the signatures are the same or shreds are not from the same erasure batch.
AshwinSekar
approved these changes
Jan 8, 2025
| @@ -956,6 +961,9 @@ pub(super) fn recover( | |||
| .map(Shred::merkle_node) | |||
| .collect::<Result<_, _>>()?; | |||
| let tree = make_merkle_tree(nodes); | |||
| // The attched signature verfies only if we obtain the same Merkle root. | |||
| // Because shreds obtained from turbine or repair are sig-verified, this | |||
| // also means that we don't need to verify signatures for recovered shreds. | |||
| if tree.last() != Some(&merkle_root) { | |||
| return Err(Error::InvalidMerkleRoot); | |||
There was a problem hiding this comment.
Now that we compare signatures is this clause impossible?
Not saying we should remove it, just want to understand the edge cases
There was a problem hiding this comment.
That is a good question.
I don't think it is possible but I cannot prove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
The commit verifies that the signatures are the same when recovering Merkle shreds.