[zk-sdk] Hide range proof and inner product proof type fields #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the
RangeProofandInnerProductProoftypes contains public fields that are more of an implementation detail than something that should be extracted by downstream projects.Summary of Changes
I updated the visibility of these fields to
pub(crate)as they shouldn't really be exposed outside of the crate. I verified that all current consumers of the zk-sdk do not make use of these fields.This change in visibility will also enable exporting out the range proof type as wasm since the dalek
CompressedRistrettoandScalartypes are not exported out with wasm_bindgen upstream.Fixes #