accounts-db: disable intrabatch account locks #4253
Draft
+350
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
force-pushed
the
20250103_simd83locking
branch
from
3e016b3 to
f748a5f
Compare
2501babe
force-pushed
the
20250103_simd83locking
branch
2 times, most recently
from
315ef3d to
546adb0
Compare
2501babe
force-pushed
the
20250103_simd83locking
branch
from
546adb0 to
91fd4f2
Compare
2501babe
force-pushed
the
20250103_simd83locking
branch
from
2fb8527 to
11d1dcb
Compare
2501babe
changed the title
talalim
reviewed
Jan 8, 2025
| Err(err) => Err(err), | ||
| }) | ||
| .collect() | ||
| if disable_intrabatch_account_locks { |
There was a problem hiding this comment.
Suggestion: This feature gate name is a little confusing as it's used here.
When disable_intrabatch_account_locks is true, this means account locks within a batch shouldn't be allowed. But it's used the other way around here.
There was a problem hiding this comment.
the idea isnt that intrabatch locks shouldnt be allowed, but that the concept of intrabatch locking will cease to exist. i will think of a clearer name tho ty
There was a problem hiding this comment.
maybe relax_intrabatch_account_locks
apfitzge
reviewed
Jan 8, 2025
| // HANA TODO the vec allocation here is unfortunate but hard to avoid | ||
| // we cannot do this in one closure because of borrow rules | ||
| // play around with alternate strategies, according to benches this may be up to | ||
| // 50% slower for small batches and few locks, but for large batches and many locks |
There was a problem hiding this comment.
bench using jemalloc? i'd think it would do a reasonable job of just keeping the mem in thread-local cache for re-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka "simd83 account locking"
TODO confirm it behaves right with the feature on, dedupe transactions via messagehash, write tests
Problem
Summary of Changes
Fixes #