Implemented Lab4 numeronym and test cases

[sirigithub]

Fixes #

Review of colleague's PR #518

Changes proposed in this PR:

• Implemented executable go program in directory 04_numeronym/sirigithub
• Implemented a function numeronyms that returns a slice of numeronyms for its input strings
• Included main method as per spec that calls the above function.
• Implemented tests for both methods

[codecov]

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #542   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     96    +1     
  Lines        1627   1638   +11     
=====================================
+ Hits         1627   1638   +11

Impacted Files	Coverage Δ
04_numeronym/sirigithub/main.go	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1460e...5483852. Read the comment docs.

[n0npax]

Looks good 👍 The only thing I could suggest is to split iteration over arguments and computing numeronym into separate functions, but it's no required in my mind.

[camscale]

LGTM. A good set of test cases too. Just one thing to fix for executing the test case.

[camscale]

LGTM. Great looking Go code. Thanks.

When you merge, can you either do a squash merge, or you could do a local rebase and squash and then force push. This ensures that master does not contain any fixup commits - just to good stuff. It keeps the history clean. If you do a rebase and force-push, ping me on slack when you've done it and i'll re-approve right away (since force pushing drops any current approvals).