Add numeronyms functionality #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickmarabeas
requested review from
anzboi,
anzdaddy,
camscale,
joshcarp,
juliaogris,
linuxmonk,
pentaphobe and
rokane
as code owners
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 79 80 +1
Lines 1345 1358 +13
=====================================
+ Hits 1345 1358 +13
Continue to review full report at Codecov.
|
brvishnu92
requested changes
Jun 19, 2019
patrickmarabeas
force-pushed
the
lab-04-pm
branch
from
da422eb to
2a3c77c
Compare
pentaphobe
requested changes
Jun 26, 2019
|
@pentaphobe PR # reference added. |
patrickmarabeas
force-pushed
the
lab-04-pm
branch
from
2a3c77c to
4e5e7a9
Compare
|
Updated doc strings |
Implemented numeronym functionality in a executable Go program which returns a slice of numeronyms given an input of n strings Closes Lab 04 (anz-bank#419)
patrickmarabeas
force-pushed
the
lab-04-pm
branch
from
4e5e7a9 to
93052ab
Compare
|
Updated to handle multi byte characters |
pentaphobe
approved these changes
Jul 4, 2019
|
LGTM @brvishnu92 please confirm you're happy with changes, some weren't dismissed automatically since the code lines weren't changed (see final review point) |
brvishnu92
approved these changes
Jul 4, 2019
|
@patrickmarabeas LGTM :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented numeronym functionality in a executable Go program which returns a slice of numeronyms given an input of n strings
Fixes #419
Review of colleague's PR #526