Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.2.1 #513

Merged
merged 1 commit into from
Sep 13, 2023
Merged

7.0.2.1 #513

merged 1 commit into from
Sep 13, 2023

Conversation

MoojMidge
Copy link
Collaborator

Update workflows to correct Matrix InputStream.Adaptive dependency version

@MoojMidge MoojMidge marked this pull request as draft September 13, 2023 02:54
@MoojMidge MoojMidge marked this pull request as ready for review September 13, 2023 02:54
@MoojMidge MoojMidge changed the title 7.0.2-1 7.0.2.1 Sep 13, 2023
@MoojMidge MoojMidge merged commit 86434a0 into anxdpanic:master Sep 13, 2023
2 checks passed
@doraskayo
Copy link

@MoojMidge, I think this wasn't released to the official repos, possibly because of this issue: https://github.com/anxdpanic/plugin.video.youtube/actions/runs/6167484626/job/16738521404

@MoojMidge
Copy link
Collaborator Author

It's all good, nothing of concern here.

v7.0.2.1 only has a Kodi Matrix specific change, made as a quick post release fix after v7.0.2

The error in the workflow is just indicating that there is already an existing PR for the plugin in the Nexus repository. A subsequent PR for the Matrix repository has also already been created.

It will just take some time for the PRs to be reviewed/approved/merged before the release appears in the official Kodi plugin repository.

JimmyS83 pushed a commit to JimmyS83/plugin.video.youtube that referenced this pull request Oct 11, 2023
@bkuhls
Copy link
Contributor

bkuhls commented Oct 29, 2023

Afaics addon.xml in plugin.video.youtube-7.0.2.2.matrix.unofficial.1.zip still contains

<import addon="inputstream.adaptive" version="20.3.1"/>

plugin.video.youtube-7.0.2.2.matrix.1.zip is fine

@MoojMidge
Copy link
Collaborator Author

Yeah, unfortunately I only noticed a little while back, after this was released.

I tried to get some people to test the Matrix versions, as they were otherwise untested (by me), however the only people who provided any feedback for it were two people using Kodi 20 (Nexus) who installed it by accident, and one person who tested 7.0.2.1.matrix.1, so it got missed.

In the meantime, it's fixed in MoojMidge@2b82ca1, but thanks for the reminder - there are also a few other minor bug fixes that need to be PR'ed.

@bkuhls
Copy link
Contributor

bkuhls commented Oct 29, 2023

I tried to get some people to test the Matrix versions, as they were otherwise untested (by me),

Meanwhile I could install https://github.com/anxdpanic/plugin.video.youtube/releases/download/v7.0.2.2/plugin.video.youtube-7.0.2.2.matrix.1.zip

Thanks for pointing out to the additional fixes in your repo of which MoojMidge@b9296e6 is really needed as it fixes

2023-10-29 12:53:21.453 T:14730    info <general>: [plugin.video.youtube] Running: YouTube (7.0.2.2+matrix.1) on Matrix (Kodi-19.5) with Python 3.9.18
[...]
Error Contents: _get() got an unexpected keyword argument 'language_name'

I also installed the rest of your fixes and I am testing right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants