Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Feature/manager #15
Adds Feature/manager #15
Changes from 5 commits
abdb193
828de8c
2f2f371
efef7b8
f18ca4b
1d903b7
3f6645d
b1821b2
111dcc9
1ae93c1
db3949c
aad0fa5
5bc84e9
e44745b
4662a12
526d3aa
8d19c36
02d9135
e4866ad
40db04f
4213252
c12b5bc
25dfcb0
6410e24
eae8fec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a step is missing here.
After running the commands above then running
pytest reported many errors.
I then ran the following from the top-level repo directory:
then pytest ran much better.
I am not sure if
pip install -e .
is the right/best command to run here, yet it seems like there is a missing step in the insturctions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Will address today in a change to this PR, (change to README)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed