fix(plugin:export): it should have default value 'true' through doc #4111
Conversation
x6-bot
bot
added
size/S
| // without instance.hasOwnProperty method cause by ts rule. | ||
| // the condition will be false if these properties have been set undefined in the target, | ||
| // but will be true if these properties are not in the target, cause the doc. | ||
| !Object.prototype.hasOwnProperty.call(options, 'copyStyle') && |
There was a problem hiding this comment.
Because the following judgment is options.copyStyles !== false, so if it is not passed, it is also executed in accordance with true.
There was a problem hiding this comment.
In fact, we just have a difference about what is the true . It will execute correctly under the strict-Boolean-type. The options.copyStyles !== false is a strict un-equality which likes ===.But, the serializeImages condition in line 209 is not strict which likes ==.So, In my option, we should keep the same style about the serializeImages and copyStyle condition what are both the Boolean value through the docs on the one hand, on the other hand, It should excute false statement when the value is either '', or ``, or null,or undefined,or NAN. All above these just beacuse JS is a fuck weak type language😓.
NewByVector
added
PR: reviewed-changes-requested
| // without instance.hasOwnProperty method cause by ts rule. | ||
| // the condition will be false if these properties have been set undefined in the target, | ||
| // but will be true if these properties are not in the target, cause the doc. | ||
| !Object.prototype.hasOwnProperty.call(options, 'copyStyle') && |
x6-bot
bot
added
PR: reviewed-approved
|
👋 @Sorryhx Congrats on merging your first pull request! 🎉🎉🎉 |
x6-bot
bot
added
PR: merged
Description
@antv/x6-plugin-export's options table show that the default-value of serializeImages and copyStyles is the true.However, the option argument has been set {} which will cause serializeImages or copyStyles is undefined in runtime. the logical truth code won't be executed.
Motivation and Context
Types of changes
Self Check before Merge