-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: selection's pointerEvents support function type #4067
feat: selection's pointerEvents support function type #4067
Conversation
@@ -126,7 +126,10 @@ export class SelectionImpl extends View<SelectionImpl.EventArgs> { | |||
const { ui, selection, translateBy, snapped } = options | |||
|
|||
const allowTranslating = | |||
(showNodeSelectionBox !== true || pointerEvents === 'none') && | |||
(showNodeSelectionBox !== true || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不好意思,这么久才来 review 代码,注意到两个地方都有相似的判断,可以提取成一个函数。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4067 +/- ##
==========================================
- Coverage 10.37% 10.36% -0.02%
==========================================
Files 180 180
Lines 10542 10563 +21
Branches 2566 2572 +6
==========================================
+ Hits 1094 1095 +1
- Misses 9359 9379 +20
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. |
"pointerEvents",one of the plugin "Selection"'s configuation,supporting function type
see #4062
"pointerEvents",one of the plugin "Selection"'s configuation,supporting function type
see #4062
Types of changes
Self Check before Merge