Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: selection's pointerEvents support function type #4067

Conversation

damnright
Copy link
Contributor

@damnright damnright commented Dec 1, 2023

"pointerEvents",one of the plugin "Selection"'s configuation,supporting function type

see #4062

"pointerEvents",one of the plugin "Selection"'s configuation,supporting function type

see #4062

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added feature feature PR: unreviewed PR does not have any reviews. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@@ -126,7 +126,10 @@ export class SelectionImpl extends View<SelectionImpl.EventArgs> {
const { ui, selection, translateBy, snapped } = options

const allowTranslating =
(showNodeSelectionBox !== true || pointerEvents === 'none') &&
(showNodeSelectionBox !== true ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思,这么久才来 review 代码,注意到两个地方都有相似的判断,可以提取成一个函数。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okk

@x6-bot x6-bot bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Jan 9, 2024
@NewByVector NewByVector added PR: unreviewed PR does not have any reviews. and removed PR: unreviewed PR does not have any reviews. labels Jan 9, 2024
@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12ca0e1) 10.37% compared to head (02218b1) 10.36%.
Report is 33 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4067      +/-   ##
==========================================
- Coverage   10.37%   10.36%   -0.02%     
==========================================
  Files         180      180              
  Lines       10542    10563      +21     
  Branches     2566     2572       +6     
==========================================
+ Hits         1094     1095       +1     
- Misses       9359     9379      +20     
  Partials       89       89              
Flag Coverage Δ
x6 10.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@damnright damnright requested a review from NewByVector January 18, 2024 01:41
@NewByVector NewByVector merged commit 6decb75 into antvis:master Jan 24, 2024
12 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature PR: merged PR has merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants