Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paning mousewheel #4035

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: paning mousewheel #4035

merged 1 commit into from
Nov 18, 2023

Conversation

yinhangfeng
Copy link
Contributor

Description

开启 panning 之后,对 mousewheel 事件增加 eventTypes 判断,如果 panning 插件无法处理则允许事件继续冒泡传播

Motivation and Context

目前开启 panning 之后鼠标放在 graph 区域滚动会被捕获,无法触发外部容器的滚动

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. fix labels Nov 14, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 14, 2023

👋 @yinhangfeng

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. pkg:x6 labels Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #4035 (14ddecc) into master (0178e48) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4035   +/-   ##
=======================================
  Coverage   10.37%   10.37%           
=======================================
  Files         180      180           
  Lines       10544    10544           
  Branches     2567     2567           
=======================================
  Hits         1094     1094           
  Misses       9361     9361           
  Partials       89       89           
Flag Coverage Δ
x6 10.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/graph/panning.ts 4.25% <0.00%> (ø)

@NewByVector NewByVector merged commit 33152c3 into antvis:master Nov 18, 2023
18 checks passed
@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 18, 2023

👋 @yinhangfeng

Congrats on merging your first pull request! 🎉🎉🎉

@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Nov 18, 2023
@yanghui123
Copy link

yanghui123 commented Jul 2, 2024

移动端画布区域不能滚动 panning关闭也是一样

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pkg:x6 PR: merged PR has merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants