Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/memory leak #4009

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Fix/memory leak #4009

merged 3 commits into from
Nov 6, 2023

Conversation

cyrilluce
Copy link
Contributor

Description

梳理 dispose 逻辑,修复 graph.dispose() 内存泄漏问题

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added fix size/M Denotes a PR that changes 30-99 lines, ignoring generated files. pkg:x6 PR: unreviewed PR does not have any reviews. labels Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #4009 (aa3ddb7) into master (b92a23e) will decrease coverage by 0.01%.
Report is 7 commits behind head on master.
The diff coverage is 31.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
- Coverage   10.35%   10.34%   -0.01%     
==========================================
  Files         180      180              
  Lines       10529    10532       +3     
  Branches     2565     2567       +2     
==========================================
  Hits         1090     1090              
- Misses       9350     9353       +3     
  Partials       89       89              
Flag Coverage Δ
x6 10.34% <31.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/graph/graph.ts 14.46% <ø> (ø)
packages/x6/src/model/collection.ts 1.41% <ø> (ø)
packages/x6/src/view/view.ts 6.04% <ø> (ø)
packages/x6/src/model/model.ts 1.63% <50.00%> (ø)
packages/x6/src/renderer/scheduler.ts 4.59% <66.66%> (ø)
packages/x6/src/view/cell.ts 10.63% <0.00%> (ø)
packages/x6/src/shape/html.ts 29.78% <22.22%> (ø)

... and 1 file with indirect coverage changes

@NewByVector NewByVector merged commit ffbc7ed into antvis:master Nov 6, 2023
9 checks passed
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Nov 6, 2023
@cyrilluce
Copy link
Contributor Author

@NewByVector x6-common 也需要一同发布,否则 plugin-scroller 可能会报错

1 similar comment
@cyrilluce
Copy link
Contributor Author

@NewByVector x6-common 也需要一同发布,否则 plugin-scroller 可能会报错

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pkg:x6 PR: merged PR has merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants