Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React UI elements #4

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

React UI elements #4

wants to merge 20 commits into from

Conversation

antrikshmisri
Copy link
Owner

This PR adds react UI components that map 1:1 to the python UI elements.

@pep8speaks
Copy link

pep8speaks commented Dec 31, 2021

Hello @antrikshmisri! Thanks for updating this PR.

Line 17:1: W293 blank line contains whitespace
Line 52:17: E127 continuation line over-indented for visual indent
Line 58:5: E303 too many blank lines (2)
Line 60:1: W293 blank line contains whitespace
Line 67:1: W293 blank line contains whitespace
Line 70:1: W293 blank line contains whitespace
Line 85:1: W293 blank line contains whitespace
Line 99:36: W292 no newline at end of file

Line 2:44: W292 no newline at end of file

Line 82:1: W293 blank line contains whitespace

Line 100:1: W293 blank line contains whitespace
Line 110:101: E501 line too long (108 > 100 characters)
Line 226:1: W293 blank line contains whitespace
Line 247:1: W293 blank line contains whitespace
Line 250:1: W293 blank line contains whitespace

Line 7:33: E128 continuation line under-indented for visual indent
Line 16:33: E128 continuation line under-indented for visual indent

Line 49:55: W292 no newline at end of file

Comment last updated at 2022-01-15 12:36:10 UTC

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #4 (bd02827) into master (a31ca58) will decrease coverage by 0.65%.
The diff coverage is 72.22%.

❗ Current head bd02827 differs from pull request most recent head 5914236. Consider uploading reports for the commit 5914236 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   86.59%   85.93%   -0.66%     
==========================================
  Files           3        3              
  Lines         179      192      +13     
  Branches       22       24       +2     
==========================================
+ Hits          155      165      +10     
- Misses         19       20       +1     
- Partials        5        7       +2     
Impacted Files Coverage Δ
electripy/elements.py 84.83% <72.22%> (-0.63%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants