Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codecov setting for test coverage check #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add codecov setting for test coverage check #37

wants to merge 1 commit into from

Conversation

wenqiq
Copy link

@wenqiq wenqiq commented Aug 30, 2022

Signed-off-by: Wenqi Qiu [email protected]

@wenqiq wenqiq changed the title Add codecov setting for test coverge check Add codecov setting for test coverage check Aug 30, 2022
@wenqiq
Copy link
Author

wenqiq commented Aug 30, 2022

I noticed that the unit test is blocked in the ci workflow. May I know what’s the consideration behind this? @wenyingd

@wenyingd
Copy link

I noticed that the unit test is blocked in the ci workflow. May I know what’s the consideration behind this? @wenyingd

I made a patch to run test in github action #41

@wenqiq wenqiq force-pushed the codecov branch 2 times, most recently from c18a233 to d90e024 Compare November 22, 2022 09:50
wenyingd
wenyingd approved these changes Feb 6, 2023
View reviewed changes
Copy link

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyingd wenyingd wenyingd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenqiq @wenyingd