Add resync cache logic upon watcher reset #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition which in watcher is trying to re-connect and ANP is deleted by the user. In this case, when the watcher re-connect, it will not receive delete event for those objects and those objects will remain in network policy controller cache and in cloud too. Here, we introduce a resync logic in which, upon any re-connect, the cache will be resynced first and then new cache will be compared with in-memory cache to figure out stale objects and explicitly delete them. Signed-off-by: Rahul Jain <[email protected]>
reachjainrahul
force-pushed
the
resync
branch
from
e6538c6
to
bfbe6cc
Compare
|
/nephe-test-e2e-agentless |
1 similar comment
|
/nephe-test-e2e-agentless |
|
/nephe-test-e2e-aks |
shenmo3
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition which in watcher is trying to re-connect and ANP is deleted by the user. In this case, when the watcher re-connect, it will not receive delete event for those objects and those objects will remain in network policy controller cache and in cloud too.
Here, we introduce a resync logic in which, upon any re-connect, the cache will be resynced first and then new cache will be compared with in-memory cache to figure out stale objects and explicitly delete them.