Add a state in cloud account config #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,7 +205,9 @@ func (c *cloudCommon) DoInventoryPoll(accountNamespacedName *types.NamespacedNam | |||
| } | |||
| accCfg.LockMutex() | |||
| defer accCfg.UnlockMutex() | |||
|
|
|||
| if !accCfg.GetAccountConfigState() { | |||
There was a problem hiding this comment.
Could you just update GetCloudAccountByName routine to return 'not found' or 'not valid' error.
There was a problem hiding this comment.
Updated the function to return, account config, found and an error.
Anandkumar26
force-pushed
the
account-config
branch
from
db9ca65
to
d97971c
Compare
|
/nephe-test-e2e-agentless |
Anandkumar26
force-pushed
the
account-config
branch
3 times, most recently
from
6b75a57
to
b018cf1
Compare
The cloud account config contains the service configs and cloud api clients. Whenever cloud account config update fails, reset the cloud account config state to invalid. Any consumer of cloud account config which make the cloud API calls should check the cloud account config state and proceed only if its in a valid state. Signed-off-by: Anand Kumar <[email protected]>
Consider a scenario where the following sequence of events are received. An ANP with Ipaddress block and ATGroup is realized -> Secret delete -> Sync with cloud finds diff and updates member -> AT Modify -> AT Modofy -> NP delete -> ProcessTrackers -> AT delete. This results in a scenario where a tracker has one appliedToSgs, there are no nps in npIndexers, prevAppliedToSgs is nil, computing NP status will result in an empty appliedToToNpMap and there by an error. Fix is to add an additional check to compute Npstatus from appliedToToNpMap and appliedToSgs. Signed-off-by: Anand Kumar <[email protected]>
Anandkumar26
force-pushed
the
account-config
branch
from
b018cf1
to
4fef02a
Compare
|
/nephe-test-e2e-agentless |
|
/nephe-test-e2e-azure |
2 similar comments
|
/nephe-test-e2e-azure |
|
/nephe-test-e2e-azure |
|
/nephe-test-e2e-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloud account config contains the service configs and cloud api clients. Whenever cloud account config update fails, set the cloud account config state to invalid.
Any consumer of cloud account config which makes the cloud API calls should check the cloud account config state and proceed only if it's in a valid state.