Add 'type' arg for antctl get bgproutes to filter bgproutes #6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atish-iaf
added
area/component/antctl
antoninbas
reviewed
Nov 27, 2024
| @@ -72,11 +73,13 @@ func HandleFunc(bq querier.AgentBGPPolicyInfoQuerier) http.HandlerFunc { | |||
|
|
|||
| var bgpRoutesResp []apis.BGPRouteResponse | |||
| for bgpRoute := range bgpRoutes { | |||
There was a problem hiding this comment.
now I feel like having the ipv4Routes, ipv6Routes bool parameters in the GetBGPRoutes querier method is not necessary or desirable, and that we should do all the filtering here, like you do for the route type. What do you think? It would be more consistent and simplify the logic in GetBGPRoutes.
There was a problem hiding this comment.
I felt the same while making these changes. I think we can also do the same for GetBGPPeerStatus as well. I will update the changes for both in this PR.
Atish-iaf
force-pushed
the
add-type-arg-for-antctl-get-bgproutes
branch
2 times, most recently
from
c5a3ed6
to
de3d86c
Compare
Also, move all filtering logic from controller to handler for consistency. Signed-off-by: Kumar Atish <[email protected]>
Atish-iaf
force-pushed
the
add-type-arg-for-antctl-get-bgproutes
branch
from
de3d86c
to
2f96853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.