Add Route info in output of "antctl get bgproutes" #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Nov 12, 2024
| // routes stores all BGP routers advertised to BGP peers. | ||
| routes sets.Set[bgp.Route] | ||
| // routes stores all BGP routes advertised to BGP peers. | ||
| routes map[AdvertisedRouteType]sets.Set[bgp.Route] |
There was a problem hiding this comment.
The ability to provide a reference to the K8s object will require a different data structure here.
Personally, I would go with something like this:
type RouteMetadata struct {
Type RouteType
K8sObjRef string
}
routes map[bgp.Route]RouteMetadata- you can easily get a set of desired routes with
sets.KeySet(c.routes), requiring only minimal changes inreconcileBGPAdvertisements - the handler will transform the data (as it already does) and filter routes if needed (based on type)
Atish-iaf
force-pushed
the
add-route-type-for-antctl-get-bgproutes
branch
2 times, most recently
from
f1854c3
to
fbf32fe
Compare
Atish-iaf
changed the title
antoninbas
reviewed
Nov 18, 2024
hongliangl
reviewed
Nov 19, 2024
antoninbas
reviewed
Nov 19, 2024
Atish-iaf
force-pushed
the
add-route-type-for-antctl-get-bgproutes
branch
from
fbf32fe
to
9b3af32
Compare
Atish-iaf
force-pushed
the
add-route-type-for-antctl-get-bgproutes
branch
2 times, most recently
from
5d7ebc9
to
0dba864
Compare
Signed-off-by: Kumar Atish <[email protected]>
Atish-iaf
force-pushed
the
add-route-type-for-antctl-get-bgproutes
branch
from
0dba864
to
bb7126a
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6794