-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not4Review]Change to include unit test data only #4616
base: main
Are you sure you want to change the base?
Conversation
a287c05
to
b0aa950
Compare
Codecov Report
@@ Coverage Diff @@
## main #4616 +/- ##
==========================================
+ Coverage 68.64% 70.10% +1.45%
==========================================
Files 400 376 -24
Lines 59450 57192 -2258
==========================================
- Hits 40809 40092 -717
+ Misses 15807 14341 -1466
+ Partials 2834 2759 -75
*This pull request uses carry forward flags. Click here to find out more.
|
b0aa950
to
bf9eeb5
Compare
There is already a branch |
@wenqiq I think it's better to use a branch in antrea repo instead of a personal branch to track the unit test coverage considering it will be a long running PR. I have also removed unused github workflows to avoid unnecessary runner resource usage. You can update the branch |
f9b72fc
to
2933e97
Compare
2933e97
to
f435f55
Compare
f435f55
to
f751c5d
Compare
f751c5d
to
af1d780
Compare
af1d780
to
bc3ba6f
Compare
7792b00
to
c001763
Compare
c001763
to
300498d
Compare
f3c5e0a
to
743ef4c
Compare
743ef4c
to
e690e82
Compare
e690e82
to
cf97c70
Compare
cf97c70
to
3d9e695
Compare
46fe043
to
745523d
Compare
745523d
to
dbcec11
Compare
.github/workflows/go.yml
Outdated
test-unit-ubuntu: | ||
needs: check-changes | ||
if: ${{ needs.check-changes.outputs.has_changes == 'yes' }} | ||
name: Unit test (ubuntu-latest) | ||
runs-on: [ubuntu-latest] | ||
steps: | ||
- name: Check-out code | ||
uses: actions/checkout@v3 | ||
- name: Set up Go using version from go.mod | ||
uses: actions/setup-go@v4 | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version-file: 'go.mod' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Consider using a matrix strategy for the setup-go action to avoid duplicating code for different operating systems.
test-unit-ubuntu: | |
needs: check-changes | |
if: ${{ needs.check-changes.outputs.has_changes == 'yes' }} | |
name: Unit test (ubuntu-latest) | |
runs-on: [ubuntu-latest] | |
steps: | |
- name: Check-out code | |
uses: actions/checkout@v3 | |
- name: Set up Go using version from go.mod | |
uses: actions/setup-go@v4 | |
uses: actions/setup-go@v3 | |
with: | |
go-version-file: 'go.mod' | |
jobs: | |
test-unit: | |
strategy: | |
matrix: | |
os: [ubuntu-latest, windows-2019] | |
name: Unit test (${{ matrix.os }}) | |
runs-on: ${{ matrix.os }} | |
steps: | |
- name: Set up Go using version from go.mod | |
uses: actions/setup-go@v3 | |
with: | |
go-version-file: 'go.mod' |
.github/workflows/go.yml
Outdated
- uses: actions/cache@v3 | ||
with: | ||
# In order: | ||
# * Module download cache | ||
# * Build cache (Linux) | ||
# * Build cache (Mac) | ||
path: | | ||
~/go/pkg/mod | ||
~/.cache/go-build | ||
~/Library/Caches/go-build | ||
%LocalAppData%\go-build | ||
key: ${{ runner.os }}-${{ env.go-cache-name }}-${{ hashFiles('**/go.sum') }} | ||
restore-keys: | | ||
${{ runner.os }}-${{ env.go-cache-name }}- | ||
- name: Run unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Consider using a matrix strategy for the cache action to avoid duplicating code for different operating systems.
- uses: actions/cache@v3 | |
with: | |
# In order: | |
# * Module download cache | |
# * Build cache (Linux) | |
# * Build cache (Mac) | |
path: | | |
~/go/pkg/mod | |
~/.cache/go-build | |
~/Library/Caches/go-build | |
%LocalAppData%\go-build | |
key: ${{ runner.os }}-${{ env.go-cache-name }}-${{ hashFiles('**/go.sum') }} | |
restore-keys: | | |
${{ runner.os }}-${{ env.go-cache-name }}- | |
- name: Run unit tests | |
jobs: | |
test-unit: | |
strategy: | |
matrix: | |
os: [ubuntu-latest, windows-2019] | |
steps: | |
- uses: actions/cache@v3 | |
with: | |
path: | | |
~/go/pkg/mod | |
~/.cache/go-build | |
~/Library/Caches/go-build | |
%LocalAppData%\go-build | |
key: ${{ runner.os }}-${{ env.go-cache-name }}-${{ hashFiles('**/go.sum') }} | |
restore-keys: | | |
${{ runner.os }}-${{ env.go-cache-name }}- |
flag_management: | ||
default_rules: | ||
carryforward: true | ||
carryforward: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Consider setting 'carryforward' to true to keep the coverage from the last successful commit when a file has no coverage data for the current commit. This can prevent sudden drops in coverage.
carryforward: false | |
flag_management: | |
default_rules: | |
carryforward: true |
86b92e2
to
4f34af2
Compare
4f34af2
to
212ab5e
Compare
212ab5e
to
c7967e7
Compare
c7967e7
to
6aa834f
Compare
b495b52
to
172006f
Compare
172006f
to
68e3bb0
Compare
68e3bb0
to
6ce2aba
Compare
6ce2aba
to
fc16302
Compare
fc16302
to
5fadb93
Compare
This is test message |
5fadb93
to
7e3ba37
Compare
7e3ba37
to
00fb7c1
Compare
00fb7c1
to
2f5018b
Compare
2f5018b
to
7910c4f
Compare
7910c4f
to
0f8f084
Compare
0f8f084
to
d90d6ce
Compare
e58fff2
to
c7ee709
Compare
c7ee709
to
621c058
Compare
12e96f4
to
e13e355
Compare
e13e355
to
c0409bb
Compare
c0409bb
to
5694ed7
Compare
5694ed7
to
335dcc2
Compare
335dcc2
to
b5537c6
Compare
Signed-off-by: Rajnish K <[email protected]> Signed-off-by: Lan Luo <[email protected]> Signed-off-by: Kumar Atish <[email protected]>
b5537c6
to
6cb67ef
Compare
The purpose of this PR is to track latest unit test coverage data on Codecov.
Signed-off-by: Lan Luo [email protected]