feat: prompt xcframework_name to avoid duplicate target names error in Xcode
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setoelkahfi
changed the title
xcframework_name to avoid duplicate target names error in Xcodexcframework_name to avoid duplicate target names error in Xcode
|
I would like to avoid prompting this. Most of the time, there is no need for seeing the xcframework name, so a command line flag is sufficient. For the same reason, I will not offer a short flag here. I agree, however, that the default name should be crate specific, thanks for pointing this out! |
|
Ok. Do you want me to close this PR? Or, I can remove the things you don't like and keep the xcframework default name change. What do you think @antoniusnaumann? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this crate!
I tried to generate multiple Swift packages and include them in one project, but Xcode complained about duplicate target names. This is because the generated
xcframeworknames are all the same. Strangely, I didn't get the prompt to supply thexcframeworkname like the package name prompt. This PR adds that prompt, with the default name being CrateName+XCFramework.