Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(engine): Rename EngineApiError #134

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore(engine): Rename EngineApiError #134

merged 1 commit into from
Nov 27, 2024

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Nov 27, 2024

Description

Small pr to rename the EngineApiError to EngineError.

@refcell refcell requested a review from clabby as a code owner November 27, 2024 22:22
@refcell
Copy link
Contributor Author

refcell commented Nov 27, 2024 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell mentioned this pull request Nov 27, 2024
Merged
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 23.4%. Comparing base (8d27cec) to head (c4f4df7).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/engine/src/client.rs 0.0% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the base branch from rf/use-l2-rpc-for-block-ref to main November 27, 2024 22:27
@refcell refcell merged commit 1e70f26 into main Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby Awaiting requested review from clabby clabby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @codecov-commenter