Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev: ModuleNotFoundError #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rachmadaniHaryono
Copy link

since werkzeug v1.0.0 ProxyFix is not on werkzeug.contrib.fixers instead on werkzeug.middleware.proxy_fix

this fix is based on following commit

searx/searx@b8b1337

@jhampson-dbre
Copy link

I am having the same issue that flask-reverse-proxy-fix is incompatible with Werkzeug>1.0 due to moving ProxyFix from werkzeug.contrib.fixers to werkzeug.middleware.proxy_fix.

@felnne Is there any chance this PR can be merged and a new package published to pypi?

@felnne
Copy link
Member

felnne commented Aug 12, 2020

Hi @jhampson-dbre,

Thanks for alerting to me to this (and thanks @rachmadaniHaryono for making it), I didn't realise someone had made a pull-request.

I actually don't actively use this library at the moment but probably will in future.

I'm happy to merge this in (and am glad it's useful to others) however I will need to update the build/release process which will probably take me a few weeks to get to if that's ok.

Thanks,
Felix

@damiencorpataux
Copy link

damiencorpataux commented Feb 1, 2021

It is starting to be urgent to merge this issue PR, as the project is currently unusable.
Shall the maintenance of this project be given to someone who actually use it ?
I'm about to publish my own fork of this project of pypi, which is a little bit stupid...

@tr1st4
Copy link

tr1st4 commented Nov 16, 2021

Hello @felnne,
First, thanks for this Flask plugin!
As stated by @damiencorpataux it's urgent to merge this PR because this project is currently unusable as dependencies have moved forward...

Can you give additional maintenance rights to allow us to use it in a clean way ?

@tr1st4
Copy link

tr1st4 commented Dec 17, 2021

Hello @felnne,
Can you just give us a state please ?

@rachmadaniHaryono
Copy link
Author

if anyone want to install this pr, you can install it from here

https://github.com/rachmadaniHaryono/flask-reverse-proxy-fix/archive/refs/tags/v0.2.2rc1.zip

https://github.com/rachmadaniHaryono/flask-reverse-proxy-fix/tree/v0.2.2rc1

guide

https://stackoverflow.com/a/13754517/1766261

@LeXofLeviafan
Copy link

This repo is stale (no commits for nearly 4 years). Can you publish your fork on PyPI (as flask-reverse-proxy-fix2 or something)?

You may want to update the readme (clarify the reason of publishing a fork with the link to original, and update the pip install example), and possibly consider including the other pull-request as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants