Implement Raise Your Hand Feature #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 73.28% 73.90% +0.61%
==========================================
Files 67 67
Lines 3070 3161 +91
Branches 692 710 +18
==========================================
+ Hits 2250 2336 +86
- Misses 737 746 +9
+ Partials 83 79 -4 ☔ View full report in Codecov by Sentry. |
burak-58
approved these changes
Jan 7, 2025
| @@ -22,6 +22,7 @@ const PinBtn = styled(Button)(({ theme }) => ({ | |||
|
|
|||
| function PublisherRequestTab(props) { | |||
| const conference = useContext(ConferenceContext); | |||
| const theme = useTheme(); | |||
|
|
|||
| const getPublisherRequestItem = (videoId) => { | |||
| sx={{ minWidth: "unset", pt: 1, pb: 1 }} | ||
| onClick={() => {conference?.approveBecomeSpeakerRequest(videoId); conference?.setRequestSpeakerList(conference?.requestSpeakerList.filter((item) => item.streamId !== videoId))}} | ||
| onClick={() => {conference?.approveBecomeSpeakerRequest(videoId); conference?.setRequestSpeakerList(conference?.requestSpeakerList.filter((item) => item !== videoId))}} | ||
| > |
There was a problem hiding this comment.
Do removal in approveBecomeSpeakerRequest method in Antmedia.js
| sx={{ minWidth: "unset", pt: 1, pb: 1 }} | ||
| onClick={() => {conference?.rejectSpeakerRequest(videoId); conference?.setRequestSpeakerList(conference?.requestSpeakerList.filter((item) => item.streamId !== videoId))}} | ||
| onClick={() => {conference?.rejectBecomeSpeakerRequest(videoId); conference?.setRequestSpeakerList(conference?.requestSpeakerList.filter((item) => item !== videoId))}} |
There was a problem hiding this comment.
Do removal in approveBecomeSpeakerRequest method in Antmedia.js
react/src/pages/AntMedia.js
Outdated
| setIsPlayOnly(false); | ||
| setInitialized(false); | ||
| setWaitingOrMeetingRoom("waiting"); | ||
| joinRoom(roomName, publishStreamId); |
There was a problem hiding this comment.
Why we call join room directly. Wait in waiting room.
test/test_webinar.py
Outdated
| @@ -690,97 +690,7 @@ def test_multiple_player(self): | |||
|
|
|||
| self.chrome.close_all() | |||
|
|
|||
| def test_request_to_speak(self): | |||
There was a problem hiding this comment.
refactor and add this in to webinar tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-media/Ant-Media-Server#6127