Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform docker splunk deployment #124

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from
Open

Terraform docker splunk deployment #124

wants to merge 35 commits into from

Conversation

CSL-Answer
Copy link
Contributor

Added config for deploying Splunk in an EC2 instance.

The terraform code is within it's own folder to avoid destroying other defined infrastructures.

@github-actions

This comment has been minimized.

Sign in to view
@PietroConvalleAD
Copy link

I think you could just add it along with the rest of the terraform code, so you can reuse the same LB rather than having a separate project

bethcryer
bethcryer suggested changes Mar 17, 2023
View reviewed changes
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/versions.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Show resolved Hide resolved
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
dependabot bot and others added 4 commits March 23, 2023 10:11
@dependabot
Bump Microsoft.AspNetCore.Mvc.Testing from 7.0.3 to 7.0.4 (#125)
5d3154d 
* Bump Microsoft.AspNetCore.Mvc.Testing from 7.0.3 to 7.0.4

Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 7.0.3 to 7.0.4.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md)
- [Commits](dotnet/aspnetcore@v7.0.3...v7.0.4)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): update packages.lock.json

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump Alba from 7.3.0 to 7.4.0 (#126)
fe16d30 
* Bump Alba from 7.3.0 to 7.4.0

Bumps [Alba](https://github.com/JasperFx/alba) from 7.3.0 to 7.4.0.
- [Release notes](https://github.com/JasperFx/alba/releases)
- [Commits](JasperFx/alba@v7.3.0...v7.4.0)

---
updated-dependencies:
- dependency-name: Alba
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): update packages.lock.json

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump AWSSDK.CloudWatchLogs from 3.7.104.33 to 3.7.104.40 (#128)
0559494 
* Bump AWSSDK.CloudWatchLogs from 3.7.104.33 to 3.7.104.40

Bumps [AWSSDK.CloudWatchLogs](https://github.com/aws/aws-sdk-net) from 3.7.104.33 to 3.7.104.40.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.CloudWatchLogs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): update packages.lock.json

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@CSL-Answer
successfully applied however, broke current splunk instance
4391999
@github-actions

This comment has been minimized.

Sign in to view
bethcryer
bethcryer suggested changes Mar 24, 2023
View reviewed changes
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
bethcryer
bethcryer suggested changes Mar 27, 2023
View reviewed changes
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Show resolved Hide resolved
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Outdated Show resolved Hide resolved
terraform/splunk/splunk.tf Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
bethcryer
bethcryer suggested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@bethcryer bethcryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkov has flagged some issues in the pipeline that need addressing. If the rule they're complaining about isn't valid, you can add an exception in the terraform code.

bethcryer
bethcryer reviewed Apr 5, 2023
View reviewed changes
terraform/versions.tf Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Tests run with 277 passed and 0 failed in 22845ms.

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethcryer bethcryer bethcryer requested changes

@PietroConvalleAD PietroConvalleAD PietroConvalleAD left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CSL-Answer @PietroConvalleAD @bethcryer