Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webview to scaffold sample execution-environment.yml file using creator add subcommand #1727

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abhikdps
Copy link
Contributor

@abhikdps abhikdps commented Dec 17, 2024

Summary

This PR adds a new webview for adding a sample execution-environment.yml file to an existing destination path.

Available fields:

  • Destination Path: The path where the sample execution-environment.yml file gets added. If the destination path does not exist, an error message comes up.

Webview

Screenshot 2024-12-17 at 2 42 54 PM

Related JIRA: AAP-36883

@alisonlhart
Copy link
Contributor

(moving this comment from the previous PR)
I'm wondering if we need to keep the log output to file, copy logs, and open log file options - similar to how the devfile webview currently is.
@audgirka What do you think?

@alisonlhart
Copy link
Contributor

Can you also add an entry in the codecov.yml file for createSampleExecutionEnvPageApp.ts? (see https://github.com/ansible/vscode-ansible/pull/1719/files)
This is because webpack mangles the app files to the point where codecov cannot read coverage data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants