remove volume mounts when execution environment is disabled (#1503)

ansible · Aug 12, 2024 · dd2335b · dd2335b
1 parent 21c587e
commit dd2335b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/ansible-language-server/test/helper.ts b/packages/ansible-language-server/test/helper.ts
@@ -58,12 +58,12 @@ export async function enableExecutionEnvironmentSettings(
     {
       src: ANSIBLE_COLLECTIONS_FIXTURES_BASE_PATH,
       dest: ANSIBLE_COLLECTIONS_FIXTURES_BASE_PATH,
-      options: undefined,
+      options: "ro", // read-only option for volume mounts
     },
     {
       src: ANSIBLE_ADJACENT_COLLECTIONS__PATH,
       dest: ANSIBLE_ADJACENT_COLLECTIONS__PATH,
-      options: undefined,
+      options: "ro", // read-only option for volume mounts
     },
   ];
 }
@@ -72,6 +72,7 @@ export async function disableExecutionEnvironmentSettings(
   docSettings: Thenable<ExtensionSettings>,
 ): Promise<void> {
   (await docSettings).executionEnvironment.enabled = false;
+  (await docSettings).executionEnvironment.volumeMounts = [];
 }
 
 export function resolveDocUri(filename: string): string {

diff --git a/test/helper.ts b/test/helper.ts
@@ -115,14 +115,15 @@ export async function enableExecutionEnvironmentSettings(): Promise<void> {
     {
       src: ANSIBLE_COLLECTIONS_FIXTURES_BASE_PATH,
       dest: ANSIBLE_COLLECTIONS_FIXTURES_BASE_PATH,
-      options: undefined,
+      options: "ro", // read-only option for volume mounts
     },
   ];
   await updateSettings("executionEnvironment.volumeMounts", volumeMounts);
 }
 
 export async function disableExecutionEnvironmentSettings(): Promise<void> {
   await updateSettings("executionEnvironment.enabled", false);
+  await updateSettings("executionEnvironment.volumeMounts", []);
 }
 
 export async function enableLightspeedSettings(): Promise<void> {