Add test for pkg/utils/flock #878

thom-at-redhat · 2023-10-18T11:52:29Z

No description provided.

codecov · 2023-10-18T12:03:43Z

Codecov Report

Merging #878 (74792e2) into devel (63ee265) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #878      +/-   ##
==========================================
+ Coverage   37.53%   37.70%   +0.17%     
==========================================
  Files          44       44              
  Lines        8576     8576              
==========================================
+ Hits         3219     3234      +15     
+ Misses       5111     5095      -16     
- Partials      246      247       +1

see 3 files with indirect coverage changes

AaronH88 · 2023-10-19T14:09:28Z

pkg/utils/flock_test.go

+			t.Parallel()
+
+			if tt.name == "Good Test" {
+				f, err := os.CreateTemp("", "")


So this style of testing creates files and directories on the system running these tests. If we look at other unit tests in receptor, we wrap these types of calls so that nothing is created on the system and we mock the responses.

Some examples of this can be found in how calls to the os library have been mocked in stdio_utils.go and then used in stdio_utils_test.go.

Please consider wrapping the syscall 's in flock using the Accept interfaces, return structs principle