Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #2374/f4faf422 backport][stable-4.10] Init django-flags #2383

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Dec 6, 2024

This is a backport of PR #2374 as merged into master (f4faf42).

Issue: AAP-35418

Add django-flags dependancy to Hub component.

verifications:

  1. add MY_FLAG to FLAGS in galaxy_ng/app/settings.py
FLAGS = {
    "MY_FLAG": []
}
  1. enable, disable flag and verify state
> docker compose -f dev/compose/aap.yaml exec manager /bin/bash
bash-4.4# django-admin enable_flag MY_FLAG
Successfully enabled MY_FLAG

bash-4.4# pulpcore-manager shell
Python 3.11.10 (main, Sep 24 2024, 09:33:51) [GCC 8.5.0 20210514 (Red Hat 8.5.0-22)]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.29.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from flags.state import flag_state, enable_flag, disable_flag

In [2]: flag_state('MY_FLAG')
Out[2]: True

In [3]: disable_flag('MY_FLAG')

In [4]: flag_state('MY_FLAG')
Out[4]: False

(django-flags in EDA: ansible/eda-server#1135)

* init django-flags
* fix TemplateDoesNotExist
* remove TEMPLATES

(cherry picked from commit f4faf42)
@patchback patchback bot mentioned this pull request Dec 6, 2024
@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rochacbruno rochacbruno merged commit 5298ca7 into stable-4.10 Dec 10, 2024
26 of 32 checks passed
@rochacbruno rochacbruno deleted the patchback/backports/stable-4.10/f4faf422a54cba2e26415997637e8cb6e008fd3f/pr-2374 branch December 10, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants