Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pulp_ansible to 0.23.1 #2360

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

fullsushidev
Copy link
Member

@fullsushidev fullsushidev commented Nov 18, 2024

What is this PR doing:

Bumping pulp_ansible version to fix FK bug found during UI tests.

Issue: AAP-30156

Reviewers must know:

This PR should be merged only after all pipelines run green, including UI tests.

PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit

Copy link
Collaborator

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change a requirement in setup.py, you also need to run package=<packagename> make requirements/pip-upgrade-single-package which utilizes pip-tools to recreate the requirements/requirements*.txt files that are used in container builds.

@rochacbruno
Copy link
Member

I think we can go directly to 0.23.1

@fullsushidev fullsushidev changed the title Bump pulp_ansible to 0.23.0 Bump pulp_ansible to 0.23.1 Nov 26, 2024
@fullsushidev
Copy link
Member Author

waiting for this to be resolved: pulp/pulp_ansible#2052

@fullsushidev fullsushidev marked this pull request as ready for review November 26, 2024 16:31
@fullsushidev fullsushidev force-pushed the bump-pulp-ansible branch 2 times, most recently from 57b9e59 to dd427cf Compare December 3, 2024 15:48
Copy link

sonarcloud bot commented Dec 3, 2024

@fullsushidev fullsushidev requested a review from jctanner December 3, 2024 16:44
@fullsushidev
Copy link
Member Author

/retest

@jctanner jctanner merged commit e477f07 into ansible:master Dec 4, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants