-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more settings to the settings endpoint. #2219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jctanner
commented
Aug 12, 2024
•
edited
Loading
edited
We regularly come across these settings when debugging install issues. No-Issue Signed-off-by: James Tanner <[email protected]>
github-actions
bot
added
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backport-4.4
This PR should be backported to stable-4.4 (2.1)
backport-4.5
This PR should be backported to stable-4.5 (2.2)
backport-4.6
This PR should be backported to stable-4.6 (2.3)
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backport-4.8
This PR should be backported to stable-4.8 (2.4)
backport-4.9
This PR should be backported to stable-4.9 (2.4)
labels
Aug 12, 2024
jctanner
removed
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backport-4.4
This PR should be backported to stable-4.4 (2.1)
backport-4.5
This PR should be backported to stable-4.5 (2.2)
backport-4.6
This PR should be backported to stable-4.6 (2.3)
backport-4.7
This PR should be backported to stable-4.7 (2.4)
backport-4.8
This PR should be backported to stable-4.8 (2.4)
backport-4.9
This PR should be backported to stable-4.9 (2.4)
labels
Aug 12, 2024
No-Issue Signed-off-by: James Tanner <[email protected]>
rochacbruno
approved these changes
Aug 12, 2024
cutwater
reviewed
Aug 12, 2024
Comment on lines
+45
to
+46
data["DYNACONF_AFTER_GET_HOOKS"] = \ | ||
[str(func) for func in settings_dict["DYNACONF_AFTER_GET_HOOKS"]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
data["DYNACONF_AFTER_GET_HOOKS"] = \ | |
[str(func) for func in settings_dict["DYNACONF_AFTER_GET_HOOKS"]] | |
data["DYNACONF_AFTER_GET_HOOKS"] = [ | |
str(func) for func in settings_dict["DYNACONF_AFTER_GET_HOOKS"] | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this for another time. I'm in a bit of a hurry to get it merged.
cutwater
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.