Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System auditor v3. #2168

Merged
merged 3 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions galaxy_ng/app/access_control/statements/roles.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,17 @@
},
"inherit_from": [],
},
# View and cancel any task.
"galaxy.auditor": {
"permissions": {
"ansible.view_ansiblerepository",
"ansible.view_collectionremote",
"core.view_task",
"galaxy.view_group",
"galaxy.view_user",
},
"inherit_from": [],
},
}


Expand Down
39 changes: 39 additions & 0 deletions galaxy_ng/tests/integration/dab/test_system_auditor.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import json
import os
import uuid

import pytest


pytestmark = pytest.mark.qa # noqa: F821


@pytest.mark.deployment_standalone
@pytest.mark.min_hub_version("4.10dev")
@pytest.mark.skipif(
os.getenv("ENABLE_DAB_TESTS"),
reason="Skipping test because ENABLE_DAB_TESTS is set"
)
def test_system_auditor_role_permissions_without_gateway(galaxy_client):
"""Tests the galaxy.system_auditor role can be added to a user and has the right perms."""

gc = galaxy_client("admin", ignore_cache=True)

# make a random user
username = str(uuid.uuid4())
uinfo = gc.post(
"_ui/v1/users/",
body=json.dumps({"username": username, "password": "redhat1234"})
)
uid = uinfo["id"]

# assign the galaxy.system_auditor role to the user
rinfo = gc.post(
f"pulp/api/v3/users/{uid}/roles/",
body=json.dumps({'content_object': None, 'role': 'galaxy.auditor'})
)

# check that all the permssions are view_* only ...
for perm_code in rinfo["permissions"]:
perm_name = perm_code.split(".", 1)[1]
assert "view_" in perm_name, f"{perm_code} is not a view-only permission"
Loading