Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit logo test: add a sleep after the initial namespace create. #2112

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

jctanner
Copy link
Collaborator

@jctanner jctanner commented Apr 1, 2024

The initial create fires off multiple async but the test isn't waiting for all of them to finish before moving on with altering the namespace.

@jctanner
Copy link
Collaborator Author

jctanner commented Apr 1, 2024

The package install test has intermittent failures too when trying to fetch the DAB repo ...

    def test_package_install(env_vars):
        """smoktest setup.py"""
    
        with tempfile.TemporaryDirectory(prefix='galaxy_ng_testing_') as basedir:
    
            # make a venv
            pid = subprocess.run(f'python3 -m venv {basedir}/venv', shell=True)
            assert pid.returncode == 0
    
            # install the package
            cmd = f'{basedir}/venv/bin/pip install .'
            if env_vars:
                for k, v in env_vars.items():
                    cmd = f'{k}={v} {cmd}'
            pid = subprocess.run(cmd, shell=True)
>           assert pid.returncode == 0
E           AssertionError: assert 1 == 0
E            +  where 1 = CompletedProcess(args='/tmp/galaxy_ng_testing_fhbi6mk8/venv/bin/pip install .', returncode=1).returncode

galaxy_ng/tests/integration/package/test_package_install.py:39: AssertionError
----------------------------- Captured stdout call -----------------------------
Processing /src/galaxy_ng
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'done'
  Preparing metadata (pyproject.toml): started
  Preparing metadata (pyproject.toml): finished with status 'done'
Collecting django-ansible-base[jwt_consumer]@ git+https://github.com/ansible/django-ansible-base@devel
  Cloning https://github.com/ansible/django-ansible-base (to revision devel) to /tmp/pip-install-ppk88_cg/django-ansible-base_891062560edc4ad981e3e03acdea6679
----------------------------- Captured stderr call -----------------------------
  Running command git clone --filter=blob:none --quiet https://github.com/ansible/django-ansible-base /tmp/pip-install-ppk88_cg/django-ansible-base_891062560edc4ad981e3e03acdea6679
  fatal: unable to access 'https://github.com/ansible/django-ansible-base/': Failed to connect to github.com port 443: Connection timed out
  error: subprocess-exited-with-error

@jctanner jctanner changed the title Add a sleep after the initial namespace create. edit logo test: add a sleep after the initial namespace create. Apr 1, 2024
@jctanner jctanner merged commit 04d36d0 into ansible:master Apr 1, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants