Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

username_autocomplete filter in legacy roles endpoint #1940

Merged
merged 3 commits into from
Oct 18, 2023
Merged

username_autocomplete filter in legacy roles endpoint #1940

merged 3 commits into from
Oct 18, 2023

Conversation

jerabekjiri
Copy link
Contributor

Issue: AAH-2782

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 17, 2023
@jerabekjiri jerabekjiri removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Oct 17, 2023
jctanner
jctanner requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filter was meant to only reduce the namespaces per https://github.com/ansible/galaxy/blob/b63a816a1fc307987c8f3a314b1b6407a8b1ece1/galaxy/api/views/search.py#L151

@jerabekjiri jerabekjiri requested a review from jctanner October 17, 2023 22:53
@jerabekjiri jerabekjiri merged commit ca12993 into ansible:master Oct 18, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jctanner jctanner jctanner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerabekjiri @jctanner