-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable social auth users to see other users. #1934
Conversation
1d7ced9
to
f3cd0a4
Compare
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
f3cd0a4
to
452a556
Compare
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I wonder from a security perspective if it's okay to expose information like 'groups,' 'is_superuser,' or 'auth_provider' to all users. Would it make sense to create a custom view for non-superusers with limited information?
|
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Issue: AAH-2781 Signed-off-by: James Tanner <[email protected]>
Failing test_copy_cv_endpoint works locally with this patch, so ignoring the failure in CI. |
Users can't see the list of users when trying to add owners to their namespaces.