-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags/roles and tags/collections endpoints #1931
Add tags/roles and tags/collections endpoints #1931
Conversation
878da66
to
db2075f
Compare
order = "-" if "-count" in value else "" | ||
|
||
return qs.filter( | ||
ansible_collectionversion__ansible_crossrepositorycollectionversionindex__is_highest=True # noqa: E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it really need to use the crossrepo
index? for community we have only one repo and it would be faster to just take the is_highest from the single repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but then this wouldn't work for PAH and CRC
db2075f
to
750d2c7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it out and see how it goes.
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("galaxy", "0041_alter_containerregistryremote_remote_ptr"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0042_namespace_created_namespace_updated
?
(there's a new migration if you rebase .. and this bit seems to produce an infinite loop when starting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍, rebased.
The collections endpoint seems to work, but the items are missing Do I need to trigger some manage command to regenerate, have a flag enabled, or something? |
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Issue: AAH-2761
Good point, I forgot to mention that you need to run |
Issue: AAH-2761
750d2c7
to
7e7f008
Compare
Issue: AAH-2761
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :) Works for me, I can see role tag counts now 👍
Issue: AAH-2761
name
andcount
for both endpointsname, name__icontains, name__contains, name__startswith
for both endpoints_ui/v1/tags/collections
:_ui/v1/tags/
)count
attribute toTagSerializer
(Addcount
attribute toTagSerializer
pulp/pulp_ansible#1612)_ui/v1/tags/roles
:django-admin populate-role-tags