Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize user v3 namespace owner lookups. #1901

Merged
merged 2 commits into from
Sep 27, 2023
Merged

optimize user v3 namespace owner lookups. #1901

merged 2 commits into from
Sep 27, 2023

Conversation

jctanner
Copy link
Collaborator

the old code is probably causing timeouts during social logins because of the number of namespaces it has to iterate through.

@jctanner
Optimize user v3 namespace owner lookups.
fb0033b 
No-Issue

Signed-off-by: James Tanner <[email protected]>
@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Sep 27, 2023
@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Sep 27, 2023
@jctanner
Add stub integration test.
05d8b87 
No-Issue

Signed-off-by: James Tanner <[email protected]>
gerrod3
gerrod3 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely look into adding a new utility function that accepts role strings so we don't have to do the conversion role->permissions, but for now this looks good.

@jctanner jctanner merged commit 80707ac into ansible:master Sep 27, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodowic drodowic drodowic approved these changes

@gerrod3 gerrod3 gerrod3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jctanner @gerrod3 @drodowic