Skip to content

Commit

Permalink
Add pull request template (#1105)
Browse files Browse the repository at this point in the history
Issue: AAH-1219
  • Loading branch information
awcrosby authored Jan 28, 2022
1 parent 0686cba commit 021ac7e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Description 🛠
_Add PR description here_

# Reviewer Checklists 👀
Developer reviewer:
- [ ] Code looks sound, good architectural decisions, no [code smells](https://www.codegrip.tech/productivity/everything-you-need-to-know-about-code-smells/)
- [ ] There is a Jira issue associated (note that "No-Issue" should be rarely used)
- [ ] Tests are included in `galaxy_ng/tests/integration` or `galaxy_ng/tests/functional`, and they fully cover necessary test scenarios… or tests not needed

QE reviewer ([exceptions](https://docs.engineering.redhat.com/display/AUTOHUB/Other+Team+Processes#OtherTeamProcesses-galaxy_ngrepo)):
- [ ] Tests are included in `galaxy_ng/tests/integration` or `galaxy_ng/tests/functional`, and they fully cover necessary test scenarios… or tests not needed
- [ ] PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit
1 change: 1 addition & 0 deletions CHANGES/1219.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add pull request template

0 comments on commit 021ac7e

Please sign in to comment.