Vendoring system for shared role definitions #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
commented
Jun 6, 2024
AlanCoding
force-pushed
the
managed_registry
branch
from
e1255dd to
8a1fe45
Compare
slemrmartin
approved these changes
Jun 7, 2024
AlanCoding
force-pushed
the
managed_registry
branch
from
96c658c to
db29752
Compare
|
thedoubl3j
pushed a commit
to thedoubl3j/django-ansible-base
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
As of creating this, I still have 1 failure, but it's meaningful as a type of pre-existing issue so I'm happy to see it.
Opening as a draft, it's still fairly early in development of this, but I have a framework that works for me.
TODO:
add a managed role for "Cow Admin", shortname "cow_admin" to test an app-defined thingduplicate some of the managed roles, because this is part of the intent of the systemadd tests for creating managed roles in migrations (will not use in AWX or test_app)post-merge TODO:
This is the replacement for removals in #296, so some kind of merge order solution will be developed for the two of these.