Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assumerole #24
base: devel
Are you sure you want to change the base?
Add assumerole #24
Changes from all commits
764bb69
5d19ff1
cf6d481
24ce59c
b50e003
35e5dcb
656ecb7
847d081
1807b76
648e8f7
4dd176a
c6a99ae
fb2a28c
5268832
d9435eb
836b5c9
e949dd2
2d48e82
ef334bc
814e586
93a28bd
1345871
a0737ef
29aee1e
86eef44
ea9d0e7
f1e4035
4e7cc43
499c494
87cd182
5d346ff
3f4340c
3e44826
b308b67
a132eeb
d441571
9883c3d
b565e0f
e876ff0
bf1ec34
753b6af
d5f99d6
b1a2129
9430333
e93e917
4ada473
0b1e5ef
fb85b7e
444d121
74b9206
c4dd94d
50fe83e
803c659
83ab18e
3f8bb9e
669ba01
881976f
53fb4a2
f7db82c
9842a9b
c75d33c
ff886aa
0dcc430
0eb6e86
164b54a
db9e869
cbeea1c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValueError
does not seem like a good fit for this kind of error. It's probably aRuntimeError
or something like that.Or perhaps a
It might also be a
ValueError
would signal to the caller that they passed something wrong into the function call. But this message seems to imply it's an unexpected platform problem or something like that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think any of these make sense and agree value isn't the correct thing in place. Only one I can see kinda not fitting is connection since errors could or could not be connection related. IMO lookup makes the most since we the actual function call is going and "lookin " something up but I am not dead set on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. That's what I often use. And the calling code would need to handle it and turn into whatever awx interface currently wants, which seems to be a
ValueError
, looking into the function below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same concern goes for this exception. Although I imagine that awx expects a
ValueError
so we can't change it w/o defining the interface first...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is my thought as well, looking at the actual error message makes it seem like this should be dev focused since we are the ones going and getting this actual value with the user inputs but could be helpful for debugging if someone hits this. kinda leaves a good flag as where things could have fallen apart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, all the exceptions are targeting the devs, so are the tracebacks. But if awx uses this somehow, we can't change it to a
LookupError
, I think.