Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible.utils #212

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Add ansible.utils #212

wants to merge 3 commits into from

Conversation

AdamEldred
Copy link

Adding just the requirements for ansible.utils (Galaxy) and google-cloud-storage (PIP) per the comments here: #92 (review)

Validated this resolves issues with netaddr requirements in AWX, namely:
Failed to import the required Python library (netaddr) on automation-job's Python /usr/bin/python3.

@@ -51,6 +52,7 @@ dependencies:
python-daemon
pyyaml
six
google-cloud-storage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which collection depends on this? We should avoid adding deps directly to awx-ee whenever possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The google-cloud-storage is required for many of the GCP collections. I really only included it per the previous comments. I could see the argument that it is more of a 3rd party dependency and should not be included. The overall PR is more focused on ansible.utils due to calls to netaddr.

Shall I remove the google-cloud-storage addition?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the google-cloud-storage python module to keep things light. This is now just adding ansible.utils.

@AdamEldred AdamEldred changed the title Add ansible.utils and google-cloud-storage Add ansible.utils Aug 30, 2023
@oleghalin
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants