Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXD][AAP-25468] AWX - updates to Instance Groups and Instances section buttons and actions #2741

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

tiyiprh
Copy link
Contributor

@tiyiprh tiyiprh commented Jul 16, 2024

https://issues.redhat.com/browse/AAP-25468

Updates to the Instance Groups and Instances section buttons, actions, etc with correct casing/state/wording.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing CCT Component tests labels Jul 16, 2024
@tiyiprh tiyiprh force-pushed the instancegroups-instances-buttons branch from a8c7b1e to 5b56083 Compare July 18, 2024 22:01
@tiyiprh tiyiprh force-pushed the instancegroups-instances-buttons branch 3 times, most recently from 75b2226 to 4d8d37b Compare August 20, 2024 13:22
@tiyiprh tiyiprh requested a review from daphnemaeve August 20, 2024 13:36
Copy link
Contributor

@daphnemaeve daphnemaeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass! They seem unrelated to the changes, so potentially rerunning can resolve them

@tiyiprh tiyiprh force-pushed the instancegroups-instances-buttons branch from bc304cd to 48752e3 Compare August 21, 2024 13:18
@tiyiprh tiyiprh force-pushed the instancegroups-instances-buttons branch from 50c3293 to a66468e Compare August 21, 2024 19:31
@tiyiprh
Copy link
Contributor Author

tiyiprh commented Aug 22, 2024

@daphnemaeve Tried to rerun and fix some of the issues in the failing test but seems like I'm still not fixing the right thing in the infrastructure test. Now there's another test failing that's not related to my PR.

Copy link

Copy link
Contributor

@prat98 prat98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All tests are passing! 🚀

@tiyiprh tiyiprh merged commit e3d4be0 into main Aug 27, 2024
40 checks passed
@tiyiprh tiyiprh deleted the instancegroups-instances-buttons branch August 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants