Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.16] nox: add actionlint to lint Github Actions workflows (#1848) #1919

Draft
wants to merge 2 commits into
base: stable-2.16
Choose a base branch
from
Draft

[stable-2.16] nox: add actionlint to lint Github Actions workflows (#1848) #1919

wants to merge 2 commits into from

Conversation

gotmax23
Copy link
Collaborator

(cherry picked from commit 3b43d64)

@gotmax23 gotmax23 changed the title nox: add actionlint to lint Github Actions workflows (#1848) [stable-2.16] nox: add actionlint to lint Github Actions workflows (#1848) Sep 18, 2024
@gotmax23
nox pip-compile: don't use env to pass nox args
caeeeba 
Using env here messes up the quoting for the args passed from the
calling workflows. Now that workflow_dispatch is disabled for the
reusable workflow, it should be safe to use GHA workflow templating
directly.

(cherry picked from commit c29f39e)
@gotmax23
nox: add actionlint to lint Github Actions workflows (ansible#1848)
4906d5a 
(cherry picked from commit 3b43d64)
@gotmax23 gotmax23 force-pushed the stable-2.16-actionlint branch from 116d30d to 4906d5a Compare September 18, 2024 18:21
@gotmax23 gotmax23 marked this pull request as draft September 18, 2024 18:21
@oraNod
Copy link
Contributor

oraNod commented Dec 11, 2024

@gotmax23 Hey, I think this one has fallen through the cracks a bit. Do you have time to work on this or would it help if I gave it a go? I see actionlint on devel and stable-2.17-18. Ideally we should get this into stable-2.16 as it's a branch we still maintain (plus it's an important safeguard given that recent exploit that did some shell injection and memory dumping). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gotmax23 @oraNod